Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subdivision_of now SubProp of part_of #3320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Subdivision_of now SubProp of part_of #3320

wants to merge 2 commits into from

Conversation

dosumis
Copy link
Contributor

@dosumis dosumis commented Jul 26, 2024 •
edited
Loading

@dosumis dosumis requested a review from cmungall July 26, 2024 15:13
@dosumis dosumis requested a review from anitacaron as a code owner July 26, 2024 15:13
@dosumis
Copy link
Contributor Author

dosumis commented Jul 26, 2024

#gogoeditdiff

@github-actions GitHub Actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2024-07-26/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-main.owl/uberon-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2024-07-26/uberon-base.owl
  • Loaded from: file:/__w/uberon/uberon/src/ontology/uberon-base-pr.owl/uberon-base.owl

Ontology imports

Ontology annotations

subdivision of http://purl.obolibrary.org/obo/uberon/core#subdivision_of

Added

@github-actions GitHub Actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/__w/uberon/uberon/branch/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

subdivision of http://purl.obolibrary.org/obo/uberon/core#subdivision_of

Added

@dosumis
Copy link
Contributor Author

dosumis commented Jul 26, 2024

Surprisingly this has no effect at all on classification! I suspect this is because of part_of assertions that would become redundant if we implement this change.

@github-actions GitHub Actions
Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall Awaiting requested review from cmungall

@anitacaron anitacaron Awaiting requested review from anitacaron anitacaron is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make subdivision_of a subproperty_of part_of
1 participant
@dosumis